Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a fourth "Revision" version part to be used. #961

Closed
Juff-Ma opened this issue Jan 6, 2024 · 3 comments
Closed

Allow a fourth "Revision" version part to be used. #961

Juff-Ma opened this issue Jan 6, 2024 · 3 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@Juff-Ma
Copy link

Juff-Ma commented Jan 6, 2024

Use case(s)

  • allows to create a version with no significant changes and bugfixes to create a version for a different kind of change. For example update a packages readme or help.
  • allows a package thats dependent on another library to use the 3-part version of the dependency to be the main part of the version while still having a part of itself for versioning (for example native bindings)
  • conforming with the nuget version spec that explicitely requires this (Where NuGetVersion diverges from Semantic Versioning)

Description

Allow a fourth "Revision" version part to be used with MinVer. So that w.x.y.z is possible to use with MinVer. If this is already possible it isn't in the documentation.

Alternatives

  • Let MinVer only update the first 3 parts and add the fourth one manually (kinda defeats the point of MinVer)
  • create a completely new Patch version even if there wasn't really a bugfix
  • create a whole new version system for bindings and only state compatible versions (would make it harder to get such information only from the Version number)
  • for bindings define the major version of the library manually and let MinVer only define the second, third and fourth part. (would be kinda confusing, for example when library version 2.4.3.2 and 3.4.3.2 exist)

Additional context

The Nuget packaging version Spec, as well as the assembly version (and i guess also the FileVersion) all support a fourth "Revision" part, however none of the major git versioning tools seem to support it.

@Juff-Ma Juff-Ma added the enhancement New feature or request label Jan 6, 2024
@adamralph
Copy link
Owner

@Juff-Ma this is not a use case I have but I'd be happy to accept a PR if the change doesn't add significant complexity. If you would like to spike the implementation I'd be happy to take a look, but I can't guarantee I'll accept a PR.

If you have budget available and are interested in engaging my professional services to get this done, please feel free to contact me at [email protected] and we can discuss details.

@Juff-Ma
Copy link
Author

Juff-Ma commented Jan 7, 2024

@adamralph As this also isn't a top priority for me i wouldn't want to pay someone to do it. However after a quick look it seems the only major change that would need to happen is to change from NuGets SemanticVersion to NuGetVersion.

I'll try to look into it myself and try to change all the references

@Juff-Ma
Copy link
Author

Juff-Ma commented Jan 8, 2024

Closing because of #962 being rightfully rejected

@Juff-Ma Juff-Ma closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
@adamralph adamralph added the wontfix This will not be worked on label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants