Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments appearing on the same line to the right of a declaration not parsed correctly #30

Open
PetarKirov opened this issue Aug 24, 2018 · 4 comments

Comments

@PetarKirov
Copy link

According to https://dlang.org/spec/ddoc#parsing:

  1. [..] If the documentation comment appears on the same line to the right of a declaration, it applies to that.

For example:
source: https://github.com/dlang/phobos/blob/f4aec67df5fd5a4f010edc79a22fe570b3691516/std/experimental/logger/core.d#L686-L701
ardox: http://dpldocs.info/experimental-docs/std.experimental.logger.core.LogLevel.html
ddoc: https://dlang.org/phobos/std_experimental_logger_core.html#.LogLevel
ddox: https://dlang.org/library-prerelease/std/experimental/logger/core/log_level.html

For context, see: dlang/phobos#6678.

@adamdruppe
Copy link
Owner

adamdruppe commented Aug 24, 2018 via email

@adamdruppe
Copy link
Owner

This should fix it: 02eb1a0

i will push new code to the dpldocs.info generator hopefully tomorrow and rebuild phobos, but I already rebuild std.experimental.logger and here is the result:

http://dpldocs.info/experimental-docs/std.experimental.logger.core.LogLevel.html

looks good now. just need to regression test before I actually push the rest of the way to production and i am out of time tonight.

@PetarKirov
Copy link
Author

Nice work, Adam!
Do you have some sort of CI diff tool like DAutoTest that can show the diff between two versions of the doc engine or two versions of library?

@adamdruppe
Copy link
Owner

adamdruppe commented Aug 30, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants