-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments appearing on the same line to the right of a declaration not parsed correctly #30
Comments
OK, I think I fixed this locally but I'll double check when I'm back
from my honeymoon. (I have a lot of parser fixes pending a push btw)
|
This should fix it: 02eb1a0 i will push new code to the dpldocs.info generator hopefully tomorrow and rebuild phobos, but I already rebuild std.experimental.logger and here is the result: http://dpldocs.info/experimental-docs/std.experimental.logger.core.LogLevel.html looks good now. just need to regression test before I actually push the rest of the way to production and i am out of time tonight. |
Nice work, Adam! |
On Wed, Aug 29, 2018 at 10:29:34PM -0700, Petar Kirov wrote:
Do you have some sort of CI diff tool like DAutoTest that can show the diff between two versions of the doc engine or two versions of library?
No, I just run it on a bunch of files I have here (including some
test.d's and the adrdox syntax documentation that does some weirder
edge cases but nothing formal) and see if it is looking ok.
|
According to https://dlang.org/spec/ddoc#parsing:
For example:
source: https://github.com/dlang/phobos/blob/f4aec67df5fd5a4f010edc79a22fe570b3691516/std/experimental/logger/core.d#L686-L701
ardox: http://dpldocs.info/experimental-docs/std.experimental.logger.core.LogLevel.html
ddoc: https://dlang.org/phobos/std_experimental_logger_core.html#.LogLevel
ddox: https://dlang.org/library-prerelease/std/experimental/logger/core/log_level.html
For context, see: dlang/phobos#6678.
The text was updated successfully, but these errors were encountered: