Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest.json not copying correctly #140

Open
SirDannyMunn opened this issue Jul 13, 2022 · 2 comments
Open

manifest.json not copying correctly #140

SirDannyMunn opened this issue Jul 13, 2022 · 2 comments

Comments

@SirDannyMunn
Copy link

SirDannyMunn commented Jul 13, 2022

Describe the bug
When I build in dev mode using npm run serve, the manifest copies across, but not all of the attributes from the original in src/manifest.json are present. Some of which are required by chrome to import the extension.

To Reproduce
npm run serve

Expected behavior
I expect the manifest.json which is copied to have the attributes which are defined in the original

Screenshots

Original manifest:
image

Build manifest:
image

Name Version
vue-cli-plugin-browser-extension 0.1.0
Operating System Windows 10
Node 16.0.0
NPM/Yarn 7.10.0
vue-cli 5.0.8
vue-cli-service 5.0.0
browser chrome

Additional Context

Also when I try adding attributes using the manifestTransformer in vue.config.js it doesn't make any different

@farzadtara
Copy link

same me ...

@adambullmer
Copy link
Owner

just kind of glancing at this, I think you may have a conflict with the PWA add on and this one. Both will export a manifest.json file. The current recommendation is to use a monorepo structure to share your code across build targets, but allow for keeping different builds/entrypoints in place for your extension code and your web app code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants