Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoPixels don't set to off when component removed or strand length updated #684

Open
tyeth opened this issue Jan 23, 2025 · 2 comments
Open
Labels
bug Something isn't working pixel-api

Comments

@tyeth
Copy link
Contributor

tyeth commented Jan 23, 2025

Changing the length of a neopixel component or removing it doesn't turn off the unused pixels.
We should probably send a fill of off, then if needed set the new pixel values.

Found testing Mini Sparkle Motion

@brentru
Copy link
Member

brentru commented Jan 23, 2025

Is this something that should be implemented on the firmware-side or the IO-side?

@brentru brentru added bug Something isn't working pixel-api labels Jan 23, 2025
@tyeth
Copy link
Contributor Author

tyeth commented Jan 25, 2025

In my head we're getting an update message (or maybe remove then add), but we only set a new value for colour when a new colour is sent. If the user changes number then we should copy the current brightness and colour after quickly setting all (max pixels supported) to off to cover any now unused pixels.
It was noticeable that going up and down in strand length didnt behave as expected, possibly until after a reboot, so maybe IO side, but seen when adding a second chain of 240 to an existing one of 256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pixel-api
Projects
None yet
Development

No branches or pull requests

2 participants