-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot compile forked repo #48
Comments
I don't know why you are seeing a build failure -- we test-compile many of the example sketches during our CI process, including 01_floppy_capture_track_test, on a couple of different boards, and the process doesn't encounter any errors. You mentioned running on pico 2. We didn't test on any rp2350 boards during CI, but I have added a PR to test build on Feather RP2350 during CI (#50) -- this failed, though in an uninteresting way, because feather 2350 is not supported by our CI scripts yet. Locally, I can build the 01_floppy_capture_track_test example for feather rp2350 hstx and don't get any multiple definition errors. I also entered a PR (#49) about the version number reporting and asked for help from a colleague. I do not release a lot of Arduino libraries and it looks like I forgot some manual steps required before a release. To help continue to troubleshoot this, please show the modifications you made to the example, and your best guess at the relevant parts of the error messages during the build. Please use the code buttons or markdown syntax to make the text display properly. Make sure you include the library version info too.
|
The modifications I made to the
The result is the pin definitions of:
These are simply the original lines 35 through 50. The version of the library I'm using is the
(This currently still has the version set to 0.3.0, awaiting the merge of your PR to bump it to 0.6.1) Here's the mess of output from the Arduino IDE:
The mentioned |
I finally noticed that those file names in the BusIO library sure looked suspicious. Why all the "whatever 2.cpp" ? So I
And now it compiles. 🤷 I have no idea how I ended up with two over-layed copies of that library. I wonder if it has something to do with iCloud syncing my Documents folder? I recently added a new computer to my iCloud account that runs a different version of MacOS and perhaps it got confused somewhere as I switched working on this project in two different places. Thanks for your assistance, and I look forward to digging into the code. |
[your message came in while I was writing this, I'll go ahead and post it] This message seems to be saying that the two definitions each duplicate symbol come from a file called I didn't check but I really doubt that Adafruit_BusIO has a file named Please make sure you can compile a busio SPIDevice example. |
I'm glad you got a successful build now! |
What are the steps required to compile a fork of this repo?
Here are the steps I've taken, and perhaps someone can point out where I went wrong.
~/Documents/Arduino/libraries
foldergit clone
to clone my fork into~/Documents/Arduino/libraries
.01_floppy_capture_track_test
example using theFile > Examples > Adafruit_Floppy
menu itemVerify
button to compile the exampleIt seems to compile everything in the library and then fails to link with many lines referring to
multiple definitions
related toAdafruit_BusIO
At the end, it reports
I have to admit I'm not very familiar with how modern Arduino libraries work. Is there some further step I need to take?
One thing that seems suspicious is that on the Release page for this project, it shows v0.5.0 to be the latest Release. But that end report indicates I'm using
v0.3.0
.But the
library.properties
file on themain
branch also says it is 0.3.0 so perhaps this is just a file that needs updating and has nothing to do with my issue.Thank you for taking the time to write this and read my issue!
The text was updated successfully, but these errors were encountered: