Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCP23018 support #65

Open
Donkie opened this issue Jun 27, 2021 · 3 comments
Open

MCP23018 support #65

Donkie opened this issue Jun 27, 2021 · 3 comments

Comments

@Donkie
Copy link
Contributor

Donkie commented Jun 27, 2021

Hi, good job on the rewrite, looks very good. Is there any plans on supporting the MCP23018 variant? It's pretty much the same as the MCP23017, with minor differences. I could use this library almost out of the box, the only issue I found so far is that this library does not support enabling the internal pull-up resistor for the OUTPUT mode, it only enables when choosing INPUT_PULLUP (which makes sense since MCP23017 only supports input pull-up.

The OUTPUT_OPEN_DRAIN mode should probably be accounted for as well then.

@caternuson
Copy link
Contributor

Maybe? The current base class is fairly specific to the push/pull variant registers. The differences seem small, but may require some more refactoring.

@Donkie
Copy link
Contributor Author

Donkie commented Jun 28, 2021

Alright. If you go ahead with this and need any help with testing on a real IC just hit me up.

@caternuson
Copy link
Contributor

FWIW, the CircuitPython library apparently "just works" with the caveat of needing to explicitly enable pull ups:
adafruit/Adafruit_CircuitPython_MCP230xx#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants