From 4d22a83d8b64ec3f9ad07a78a3a882f0dfd2e0d8 Mon Sep 17 00:00:00 2001
From: UnderKoen <koenvanstaveren@hotmail.com>
Date: Mon, 28 Oct 2024 18:17:19 +0100
Subject: [PATCH 1/3] fix: date handlebar functions

---
 packages/loot-core/src/server/accounts/rules.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/loot-core/src/server/accounts/rules.ts b/packages/loot-core/src/server/accounts/rules.ts
index 280e84e655b..dd82192205e 100644
--- a/packages/loot-core/src/server/accounts/rules.ts
+++ b/packages/loot-core/src/server/accounts/rules.ts
@@ -76,10 +76,10 @@ function registerHandlebarsHelpers() {
     min: mathHelper((a, b) => Math.min(a, b)),
     max: mathHelper((a, b) => Math.max(a, b)),
     fixed: (a: unknown, digits: unknown) => Number(a).toFixed(Number(digits)),
-    day: (date: string) => format(date, 'd'),
-    month: (date: string) => format(date, 'M'),
-    year: (date: string) => format(date, 'yyyy'),
-    format: (date: string, f: string) => format(date, f),
+    day: (date?: string) => date && format(date, 'd'),
+    month: (date?: string) => date && format(date, 'M'),
+    year: (date?: string) => date && format(date, 'yyyy'),
+    format: (date?: string, f?: string) => date && f && format(date, f),
     debug: (value: unknown) => {
       console.log(value);
     },

From 1b0d6ae8525366a5611690db8cc8235bce63e052 Mon Sep 17 00:00:00 2001
From: UnderKoen <koenvanstaveren@hotmail.com>
Date: Mon, 28 Oct 2024 18:26:42 +0100
Subject: [PATCH 2/3] chore: release note

---
 upcoming-release-notes/3749.md | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 upcoming-release-notes/3749.md

diff --git a/upcoming-release-notes/3749.md b/upcoming-release-notes/3749.md
new file mode 100644
index 00000000000..05d541ec4f3
--- /dev/null
+++ b/upcoming-release-notes/3749.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [UnderKoen]
+---
+
+Fix usage of date functions in action rule templating.

From 9a76988146c7999b5927dc80306ec4bddef20aef Mon Sep 17 00:00:00 2001
From: UnderKoen <koenvanstaveren@hotmail.com>
Date: Mon, 28 Oct 2024 18:26:53 +0100
Subject: [PATCH 3/3] chore: tests

---
 packages/loot-core/src/server/accounts/rules.test.ts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/packages/loot-core/src/server/accounts/rules.test.ts b/packages/loot-core/src/server/accounts/rules.test.ts
index 6352bee9aec..b0b0f24654b 100644
--- a/packages/loot-core/src/server/accounts/rules.test.ts
+++ b/packages/loot-core/src/server/accounts/rules.test.ts
@@ -406,6 +406,10 @@ describe('Action', () => {
       testHelper('{{month "2002-07-25"}}', '7');
       testHelper('{{year "2002-07-25"}}', '2002');
       testHelper('{{format "2002-07-25" "MM yyyy d"}}', '07 2002 25');
+      testHelper('{{day undefined}}', '');
+      testHelper('{{month undefined}}', '');
+      testHelper('{{year undefined}}', '');
+      testHelper('{{format undefined undefined}}', '');
     });
 
     test('{{debug}} should log the item', () => {