Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Certain splits always show as needing more funds. #4220

Open
1 task done
youngcw opened this issue Jan 22, 2025 · 2 comments · May be fixed by #4225
Open
1 task done

[Bug]: Certain splits always show as needing more funds. #4220

youngcw opened this issue Jan 22, 2025 · 2 comments · May be fixed by #4225
Labels
bug Something isn't working regression This bug appeared after a recent release and needs to be fixed before the next release
Milestone
v25.2.0

Comments

@youngcw
Copy link
Member

youngcw commented Jan 22, 2025 •
edited
Loading

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

If an existing transaction is turned into a split, the check for sum(child_amounts)=parent_amount is always showing even if the children add up.

Image

I checked a file export and it looks like the transaction is getting flagged as having an error in the db with the "missing" amount. So maybe whats happening is that the error is not removed when the transaction is balanced and saved. Then when the account is opened again, the error is still in the db and is showed as the missing amount popover.

The "fix splits" option does not fix this, and it is still exists on a new transaction if the original is duplicated.

How can we reproduce the issue?

Steps to recreate:

  1. Open edge build
  2. Modify an existing transaction to be a split
  3. Make the split lines match the parent total, see the popover go away.
  4. Navigate away from the account, then go back into the account. The popover will act like there is a broken split even though the amounts add up.

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None
@youngcw youngcw added the bug Something isn't working label Jan 22, 2025
@youngcw youngcw added this to the v25.2.0 milestone Jan 22, 2025
@youngcw
Copy link
Member Author

youngcw commented Jan 22, 2025

As a side note, the popover always has a scrollbar, which is strange. Also if the split is a deposit, then the "amount left" amount will change between positive and negative when the split expansion is toggled

@youngcw youngcw added the regression This bug appeared after a recent release and needs to be fixed before the next release label Jan 22, 2025
@matt-fidd matt-fidd linked a pull request Jan 23, 2025 that will close this issue
Open
@run4est
Copy link

run4est commented Jan 23, 2025

@youngcw the scrollbar can be removed by changing the hardcoded maxHeight of the popover to 42px.
packages/desktop-client/src/components/transactions/TransactionsTable.jsx
line 1139: style={{ width: 375, padding: 5, maxHeight: '42px !important' }}
But it reappears based on the amount 10 digits including decimal place or negatives values with 9 digits including decimal place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working regression This bug appeared after a recent release and needs to be fixed before the next release
Projects
None yet
Milestone
v25.2.0
Development

Successfully merging a pull request may close this issue.

Fix persistent split error popover matt-fidd/actual
2 participants
@youngcw @run4est