Fix persistent split error popover #4225

matt-fidd · 2025-01-23T18:12:23Z

I'm not entirely sure this is the right fix, but it does work. The problem came because not passing an error object at all leaves the error field unchanged when the db is updated.

I'd like either @jfdoming or @MatissJanis 's eyes on this as their PRs have touched it recently.

netlify · 2025-01-23T18:12:48Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`a4e9b1c`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67928889ce03c900088165de
😎 Deploy Preview	https://deploy-preview-4225.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-01-23T18:13:57Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
15	6.68 MB → 6.68 MB (-271 B)	-0.00%

Changeset

File	Δ	Size
`node_modules/define-data-property/index.js`	📉 -9 B (-0.39%)	2.25 kB → 2.24 kB
`home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts`	📉 -34 B (-0.40%)	8.35 kB → 8.32 kB
`node_modules/call-bind/index.js`	📉 -9 B (-0.84%)	1.05 kB → 1.04 kB
`node_modules/has-property-descriptors/index.js`	📉 -9 B (-1.55%)	582 B → 573 B
`node_modules/es-define-property/index.js`	📉 -210 B (-37.50%)	560 B → 350 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/index.js	4.28 MB → 4.28 MB (-271 B)	-0.01%

Unchanged

Asset	File Size	% Changed
static/js/nl.js	58.58 kB	0%
static/js/en-GB.js	92.98 kB	0%
static/js/en.js	99.31 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/uk.js	111.19 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/pt-BR.js	103.38 kB	0%
static/js/AppliedFilters.js	10.52 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/narrow.js	84.94 kB	0%
static/js/wide.js	102.8 kB	0%
static/js/ReportRouter.js	1.59 MB	0%

github-actions · 2025-01-23T18:13:58Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB → 1.33 MB (-6 B)	-0.00%

Changeset

File	Δ	Size
`packages/loot-core/src/shared/transactions.ts`	📉 -58 B (-0.55%)	10.35 kB → 10.29 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
kcab.worker.js	1.33 MB → 1.33 MB (-6 B)	-0.00%

Unchanged

No assets were unchanged

coderabbitai · 2025-01-23T18:25:34Z

Walkthrough

The pull request introduces changes to how transaction errors are handled across multiple files in the Actual application. In the transaction.d.ts type definition, the error property of the TransactionEntity interface is modified to allow null values. Corresponding changes are made in the transactions.ts file, where the recalculateSplit and splitTransaction functions are updated to simplify error handling logic. The TransactionsTable.test.tsx file is also updated to reflect these changes, with the error property being explicitly set to null in test cases.

Assessment against linked issues

Objective	Addressed	Explanation
Fix split transaction error persistence	✅
Resolve issue of splits always showing as needing more funds	✅

Possibly related PRs

recalculateSplit one last time to clear any erroneous errors #3624: Modifications to the recalculateSplit function related to transaction error handling
Fix various split transaction edits not working #4186: Handling of error property in transaction-related functions
Identify and fix broken transfers #4216: Enhancements to transaction repair process

Suggested labels

bug, transactions, error-handling

Suggested reviewers

jfdoming
MatissJanis

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f5e5d4 and a4e9b1c.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4225.md is excluded by !**/*.md

📒 Files selected for processing (3)

packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx (1 hunks)
packages/loot-core/src/shared/transactions.ts (2 hunks)
packages/loot-core/src/types/models/transaction.d.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Visual regression
GitHub Check: Functional
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)

🔇 Additional comments (4)

packages/loot-core/src/types/models/transaction.d.ts (1)

34-34: LGTM! The type change aligns with the PR objective.

Making the error property explicitly nullable helps address the persistent split error popover issue by allowing the error to be explicitly cleared.

packages/loot-core/src/shared/transactions.ts (2)

85-86: LGTM! Clean error handling in recalculateSplit.

The simplified error assignment clearly shows when the error is cleared (null) versus when a split error is created.

315-315: LGTM! Consistent error handling in splitTransaction.

The error handling follows the same pattern as recalculateSplit, maintaining consistency across the codebase.

packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx (1)

1021-1021: LGTM! Test updated to match new error handling.

The test expectation is updated to verify that error is explicitly set to null when no error exists, aligning with the type and implementation changes.

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

youngcw · 2025-01-23T20:48:21Z

Seems to fix things. That change makes sense to me, always pass something instead of only passing in an active error.

matt-fidd requested review from MatissJanis and jfdoming January 23, 2025 18:12

actual-github-bot bot changed the title ~~Unset transaction error in the database if cleared~~ [WIP] Unset transaction error in the database if cleared Jan 23, 2025

actual-github-bot bot added the 🚧 WIP label Jan 23, 2025

unset transaction error in db when no longer present

11af23e

matt-fidd force-pushed the fix-splits branch 2 times, most recently from e0a0c9d to 45d10aa Compare January 23, 2025 18:20

note

a4e9b1c

matt-fidd force-pushed the fix-splits branch from 45d10aa to a4e9b1c Compare January 23, 2025 18:20

matt-fidd changed the title ~~[WIP] Unset transaction error in the database if cleared~~ Fix persistent split error popover Jan 23, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix persistent split error popover #4225

Fix persistent split error popover #4225

matt-fidd commented Jan 23, 2025 •

edited

Loading

netlify bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

coderabbitai bot commented Jan 23, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

youngcw commented Jan 23, 2025

Fix persistent split error popover #4225

Are you sure you want to change the base?

Fix persistent split error popover #4225

Conversation

matt-fidd commented Jan 23, 2025 • edited Loading

netlify bot commented Jan 23, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Jan 23, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Jan 23, 2025 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Jan 23, 2025

Walkthrough

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

youngcw commented Jan 23, 2025

matt-fidd commented Jan 23, 2025 •

edited

Loading

netlify bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)