Improvement: Proposed name change of FTF -> GBTS seeding #2943
Closed
Rosie-Hasan
started this conversation in
General
Replies: 3 comments
-
My only request is to write |
Beta Was this translation helpful? Give feedback.
0 replies
-
Comments from my side:
|
Beta Was this translation helpful? Give feedback.
0 replies
-
Thank you both, I have made the name changes based on these suggestions and will submit a PR soon |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Change naming of new seeding algorithm from FTF (FastTrackFinder) to GBTS (Graph Based Track Seeding) as this is a clearer desription of the algorithm.
Code implemented in PRs #2227 #2726 and more details given presented at ACTS-ITK presention .
The proposed name changes for file names and classes are listed below. I would apprecaite any opinions or feedback on these before the 20th of December, when I will submit a PR of these changes.
SeedFinderFTF
->GBTSSeedFinder
(orSeedFinderGBTS
?)GNN_DataStorage
->GBTSDataStorage
GNN_Geometry
->GBTSGeometry
SeedingFTFAlgorithm
->GBTSSeedingAlgorithm
(orSeedingGBTSAlgorithm
?)FasTrackConnector
->GBTSConnector
TrigBase
->GBTSBase
full_chain_itk_FTF.py
->full_chain_itk_GBTS.py
Beta Was this translation helpful? Give feedback.
All reactions