From d745ce22f0ca10c4067509b5deafd26503cd278e Mon Sep 17 00:00:00 2001 From: Andrew Tavis McAllister Date: Fri, 13 Dec 2024 10:36:19 +0100 Subject: [PATCH] Remove unneeded step from PR template and update pr commit check --- .github/PULL_REQUEST_TEMPLATE.md | 1 - .github/workflows/pr_maintainer_checklist.yaml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0d02e9007..a9169253f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,7 +7,6 @@ Thank you for your pull request! 🚀 - [] This pull request is on a [separate branch](https://docs.github.com/en/get-started/quickstart/github-flow) and not the main branch -- [] I have given maintainers the ability to edit this pull request - [] I have run the tests for the backend and frontend depending on what's needed for my changes as described in the [testing section of the contributing guide](CONTRIBUTING.md#testing) --- diff --git a/.github/workflows/pr_maintainer_checklist.yaml b/.github/workflows/pr_maintainer_checklist.yaml index 66e016997..f4b697f22 100644 --- a/.github/workflows/pr_maintainer_checklist.yaml +++ b/.github/workflows/pr_maintainer_checklist.yaml @@ -41,4 +41,4 @@ jobs: - [ ] The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution - The contributor's name and icon in remote commits should be the same as what appears in the PR - - If there's a mismatch, the contributor needs to make sure that the [email they use for GitHub](https://github.com/settings/emails) matches what they have for `git config user.email` in their local activist repo + - If there's a mismatch, the contributor needs to make sure that the [email they use for GitHub](https://github.com/settings/emails) matches what they have for `git config user.email` in their local activist repo (can be set with `git config --global user.email "GITHUB_EMAIL"`)