From d453d42e1797baed7be851d59b595849e6733934 Mon Sep 17 00:00:00 2001 From: Saul Moncada Date: Wed, 12 May 2021 20:38:44 -0400 Subject: [PATCH 1/2] First version: save ids to result (only postgres) --- lib/active_admin_import/import_result.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/active_admin_import/import_result.rb b/lib/active_admin_import/import_result.rb index 8ff75c4..8d7c57d 100644 --- a/lib/active_admin_import/import_result.rb +++ b/lib/active_admin_import/import_result.rb @@ -1,16 +1,18 @@ # frozen_string_literal: true module ActiveAdminImport class ImportResult - attr_reader :failed, :total + attr_reader :failed, :ids, :total def initialize @failed = [] + @ids = [] @total = 0 end def add(result, qty) @failed += result.failed_instances - @total += qty + @ids += result.ids + @total += qty end def imported_qty From 54fb15b5095b59bdc299036d81e42965293a4332 Mon Sep 17 00:00:00 2001 From: Saul Moncada Date: Wed, 12 May 2021 21:28:38 -0400 Subject: [PATCH 2/2] Add spec for import_result.ids --- spec/import_result_spec.rb | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/spec/import_result_spec.rb b/spec/import_result_spec.rb index 266ceed..32c248a 100644 --- a/spec/import_result_spec.rb +++ b/spec/import_result_spec.rb @@ -14,15 +14,23 @@ ] end + let(:ids){ [1,2] } + before do @result = double \ - failed_instances: failed_instances + failed_instances: failed_instances, + ids: ids end it 'should work without any failed instances' do expect(import_result.failed_message).to eq('') end + it 'should store the supplied ids' do + import_result.add(@result, 4) + expect(import_result.ids).to eq(ids) + end + it 'should work' do import_result.add(@result, 4) expect(import_result.failed_message)