Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caches grow unbounded #447

Closed
2 of 5 tasks
schmidtw opened this issue Dec 16, 2023 · 6 comments
Closed
2 of 5 tasks

caches grow unbounded #447

schmidtw opened this issue Dec 16, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@schmidtw
Copy link

Description:
In a Github Enterprise account the caches are growing in an unbounded manor. I don't see this problem on open source Github accounts.

image

Action version:
actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:
1.21.5

Repro steps:
We run a workflow with the following configuration:

      - name: Setup go version
        uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
        with:
          go-version: ${{ inputs.go-version }}
          check-latest: ${{ inputs.go-version-latest }}
          cache-dependency-path: ${{ inputs.working-directory }}

This results in several hundred MB of cached objects to be created with unique names and never cleaned up.

Expected behavior:
Only a few cached objects will be created and used, alternatively allow cached objects to be better configured since we have to pay for the storage.

Actual behavior:
Each time we setup-go in a build (which can be 3-4 different jobs) creates duplicate caches that appear to never be reused or cleaned up when in an enterprise context.

@schmidtw schmidtw added bug Something isn't working needs triage labels Dec 16, 2023
@marko-zivic-93
Copy link
Contributor

Hello @schmidtw
Thank you for creating this issue. We will investigate it and come back to you with our findings.

@priyagupta108
Copy link
Contributor

Hello @schmidtw
Thanks for reporting this. I could not reproduce the issue on my end. Could you please provide us more details, specifically, how often updates are being made to your go.mod and go.sum files?

@priyagupta108
Copy link
Contributor

Hi @schmidtw, just a gentle reminder about the details we asked for earlier. Thanks!

1 similar comment
@aparnajyothi-y
Copy link

Hi @schmidtw, just a gentle reminder about the details we asked for earlier. Thanks!

@priyagupta108
Copy link
Contributor

Hello @schmidtw,
Due to inactivity on this issue, I am going to proceed with closing it.
Please feel free to reopen the issue if necessary, or create a new one. Thank you :)

@peterbourgon
Copy link

See #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants