Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when configuration is invalid #742

Open
QuLogic opened this issue Jan 11, 2024 · 1 comment
Open

Error when configuration is invalid #742

QuLogic opened this issue Jan 11, 2024 · 1 comment
Labels
feature request New feature or request to improve the current logic

Comments

@QuLogic
Copy link

QuLogic commented Jan 11, 2024

Description:
When setting up this action, I accidentally forgot the changed-files key in my labeler.yml, i.e., I had something like:

label:
  - any-glob-to-any-file: ['some/file/name']

instead of:

label:
  - changed-files:
    - any-glob-to-any-file: ['some/file/name']

The result was that this action just printed out:

An unknown config option was under label: any-glob-to-any-file

and returned success.

Instead, it should error so that one knows that the configuration is broken.

Justification:
Silent failures lead to people assuming things are "working fine" when they are not, and thus never investigate an issue.

Are you willing to submit a PR?
Maybe, but I don't really know TypeScript.

@QuLogic QuLogic added feature request New feature or request to improve the current logic needs triage labels Jan 11, 2024
@HarithaVattikuti
Copy link
Contributor

Hello @QuLogic
Thank you for creating this feature. We will investigate it and get back to you as soon as we have some feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants