You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 3, 2022. It is now read-only.
If a stream passed to sendStream or any other of the streaming methods emits a close event and uses an end event instead of the end() method, the send method will hang. This is reproducible by sending a file read stream with emitClose = true, and is fixed by setting it to false. Oddly, this does not seem to come up in the artifact or cache toolkit libraries that use this, but I'm passing the stream directly to sendStream and not doing anything else to it. It can be reproduced by manually sending end and close to a PassThrough stream (in any order) as well. Note that callingend and emitting close works fine, it only happens when you emit end with emit() instead of calling the method.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If a stream passed to
sendStream
or any other of the streaming methods emits aclose
event and uses anend
event instead of theend()
method, the send method will hang. This is reproducible by sending a file read stream withemitClose = true
, and is fixed by setting it tofalse
. Oddly, this does not seem to come up in the artifact or cache toolkit libraries that use this, but I'm passing the stream directly tosendStream
and not doing anything else to it. It can be reproduced by manually sendingend
andclose
to aPassThrough
stream (in any order) as well. Note that callingend
and emittingclose
works fine, it only happens when you emitend
withemit()
instead of calling the method.The text was updated successfully, but these errors were encountered: