generated from actions/container-toolkit-action
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isFirstIssue() won't work in case author has only PRs in their recent history #233
Open
kartben opened this issue
Apr 26, 2023
· 2 comments
· Fixed by zephyrproject-rtos/action-first-interaction#2 · May be fixed by #296
Open
isFirstIssue() won't work in case author has only PRs in their recent history #233
kartben opened this issue
Apr 26, 2023
· 2 comments
· Fixed by zephyrproject-rtos/action-first-interaction#2 · May be fixed by #296
Comments
Hello! Thank you for filing an issue. If this is a bug report, please include relevant logs to help us debug the problem. |
kartben
added a commit
to kartben/first-interaction
that referenced
this issue
Apr 26, 2023
Also use /search API for finding first issue, as previous upstream implementation had issues when author had only done PRs recently. Fixes actions#233 Signed-off-by: Benjamin Cabé <[email protected]>
kartben
added a commit
to kartben/first-interaction
that referenced
this issue
Apr 26, 2023
Also use /search API for finding first issue, as previous upstream implementation had issues when author had only done PRs recently. Fixes actions#233 Signed-off-by: Benjamin Cabé <[email protected]>
stephanosio
pushed a commit
to zephyrproject-rtos/action-first-interaction
that referenced
this issue
Apr 27, 2023
Also use /search API for finding first issue, as previous upstream implementation had issues when author had only done PRs recently. Fixes actions#233 Signed-off-by: Benjamin Cabé <[email protected]>
This should be fixed by #296 :) This approach uses GraphQL instead of the REST API, which will let you filter by the type (issue/PR) and creator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The way isFirstIssue() works today makes it sometimes improperly flag an issue as "new" if the only types of issues/PRs found in the list returned by "listForRepo" is PRs
The text was updated successfully, but these errors were encountered: