Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Client ID as an alternative input to Client Secret #136

Open
cloudshiftchris opened this issue May 12, 2024 · 3 comments
Open

Support Client ID as an alternative input to Client Secret #136

cloudshiftchris opened this issue May 12, 2024 · 3 comments
Labels
feature New feature or request

Comments

@cloudshiftchris
Copy link

GitHub now recommends using the clientId instead of the appId/privateKey

Augment the options to allow clientId/clientSecret, validating that either this pair or appId/privateKey are provided, and pass these options along in the call to createAppAuth.

@gr2m
Copy link
Contributor

gr2m commented May 13, 2024

Just to clarify, you cannot use the Client Secret, the private key is still required. But the OAuth Client ID is now recommended to be used as a substitute to the numeric app ID for github.com, and probably GitHub Enterprise Server 3.14+

We just shipped support for passing the client ID to Octokit's app authentication strategy:
https://github.com/octokit/auth-app.js/releases/tag/v7.1.0

@gr2m gr2m changed the title Support now-recommended clientId/clientSecret Support Client ID as an alternative input to Client Secret May 13, 2024
@gr2m gr2m added the feature New feature or request label May 13, 2024
@joebowbeer
Copy link

@cloudshiftchris edit title to clarify that support is sought for using clientId instead of appId?

@gr2m are you saying this is already supported via octokit/auth-app.js#606 ?

@gr2m
Copy link
Contributor

gr2m commented Aug 8, 2024

@gr2m are you saying this is already supported via octokit/auth-app.js#606 ?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants