Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subscribing to events via wss://webhook-forwarder.github.com to avoid firewall issues #2872

Open
dhirschfeld opened this issue Sep 6, 2023 · 3 comments
Labels
enhancement New feature or request needs triage Requires review from the maintainers

Comments

@dhirschfeld
Copy link

What would you like added?

Allow subscribing to events via wss://webhook-forwarder.github.com

Why is this needed?

This will allows users to connect to a websockent endpoint to receive events which means that the firewall only needs to allow outbound connections and thus doesn't expose your infrastructure tothe internet, making it significantly more secure.

Additional context

As implemented in the GitHub CLI: https://github.com/cli/gh-webhook

@dhirschfeld dhirschfeld added enhancement New feature or request needs triage Requires review from the maintainers labels Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

@dhirschfeld
Copy link
Author

@dhirschfeld
Copy link
Author

@gr2m has implemented the api in JavaScript which might serve as a useful reference:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

1 participant