-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for self-hosted windows runners #45
Comments
In the current state the action mainly targets the official GitHub runners. I am happy to accept PRs to expand the support here, but I have no way to test it. Besides installing bash, you also have to figure out how to install rustup. There is some support for installing rustup ( setup-rust-toolchain/action.yml Lines 125 to 132 in 4d1965c
The requirements could be better documented. A bash that is not ancient and currently an installed version of rustup. With the rustup installation fixed/updated this might be traded with curl support. |
Ahh yep ok that makes sense. I was hoping to set up the Github Action such that it would be able to bootstrap an otherwise clean Windows install into a build machine, but that seems pretty difficult to pull off. I ended up installing git (which came with bash) and rustup (which first required an install of Visual Studio via a GUI installer) and for my use case I also need signtool and a vendor-specific tool for accessing a hardware signing token. So I think I'm just going to accept that this needs some manual setup, and leave myself a trail of documentation. |
I'm building a Tauri app on a self-hosted Windows runner. Here's the relevant bit of the action yaml:
The output from the action looks like:
It looks like this repo's
action.yml
handles Windows in a couple spots but maybe not all, and I think the Github-hosted runners do actually have bash installed so this works fine there.I'd also be fine with adding a step to install bash if that seems better, though the answer here makes that sound like it might not be the right path.
The text was updated successfully, but these errors were encountered: