Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions 0.1.9 and 0.1.10 force slack action creation #168

Open
wgs-jasminkos opened this issue Feb 10, 2025 · 1 comment
Open

Actions 0.1.9 and 0.1.10 force slack action creation #168

wgs-jasminkos opened this issue Feb 10, 2025 · 1 comment

Comments

@wgs-jasminkos
Copy link

wgs-jasminkos commented Feb 10, 2025 •
edited
Loading

I am using datahub docker quickstart with compose file to setup my environment. I use the acryldata/datahub-actions:v0.1.10 as base image for my Dockerfile. In the requirements.txt among other things I have

  • acryl-datahub[datahub-rest]==0.15.0.1
  • acryl-datahub-actions==0.1.8

I have set
- DATAHUB_ACTIONS_SLACK_ENABLED=false
- DATAHUB_ACTIONS_SLACK_DATAHUB_BASE_URL="whatever"
- DATAHUB_ACTIONS_SLACK_BOT_TOKEN="whatever"
- DATAHUB_ACTIONS_SLACK_SIGNING_SECRET="whatever"
- DATAHUB_ACTIONS_SLACK_CHANNEL="whatever"
# - DATAHUB_ACTIONS_TEAMS_ENABLED=false
- DATAHUB_ACTIONS_TEAMS_WEBHOOK_URL="whatever"

All of the above ENV variables seem to be required so that may be a separate issue. I'd expect to need to seup only slack and TEAMS ENABLED = false, but for Teams that one is not needed at all which is kind of strange.

The above setup work just fine and the container starts without any issues. The problem is when I adjust acryl-datahub-actions==0.1.8 to 0.1.9 or 0.1.10. There I get the following error:

2025-02-10 13:13:18 [2025-02-10 12:13:18,843] ERROR    {datahub_actions.entrypoints:122} - File "/datahub-ingestion/.venv/lib/python3.10/site-packages/datahub_actions/cli/actions.py", line 42, in pipeline_config_to_pipeline
2025-02-10 13:13:18     37   def pipeline_config_to_pipeline(pipeline_config: dict) -> Pipeline:
2025-02-10 13:13:18     38       logger.debug(
2025-02-10 13:13:18     39           f"Attempting to create Actions Pipeline using config {pipeline_config.get('name')}"
2025-02-10 13:13:18     40       )
2025-02-10 13:13:18     41       try:
2025-02-10 13:13:18 --> 42           return Pipeline.create(pipeline_config)
2025-02-10 13:13:18     43       except Exception as e:
2025-02-10 13:13:18 
2025-02-10 13:13:18 File "/datahub-ingestion/.venv/lib/python3.10/site-packages/datahub_actions/pipeline/pipeline.py", line 122, in create
2025-02-10 13:13:18     117  def create(cls, config_dict: dict) -> "Pipeline":
2025-02-10 13:13:18     118      # Bind config
2025-02-10 13:13:18     119      config = PipelineConfig.parse_obj(config_dict)
2025-02-10 13:13:18     120  
2025-02-10 13:13:18     121      if not config.enabled:
2025-02-10 13:13:18 --> 122          raise Exception(
2025-02-10 13:13:18     123              "Pipeline is disabled, but create method was called unexpectedly."
2025-02-10 13:13:18 
2025-02-10 13:13:18 Exception: Pipeline is disabled, but create method was called unexpectedly.
2025-02-10 13:13:18 
2025-02-10 13:13:18 The above exception was the direct cause of the following exception:
2025-02-10 13:13:18 
2025-02-10 13:13:18 File "/datahub-ingestion/.venv/lib/python3.10/site-packages/datahub_actions/entrypoints.py", line 114, in main
2025-02-10 13:13:18     111  def main(**kwargs):
2025-02-10 13:13:18 No user action configurations found. Not starting user actions.
2025-02-10 13:13:18     112      # This wrapper prevents click from suppressing errors.
2025-02-10 13:13:18     113      try:
2025-02-10 13:13:18 --> 114          sys.exit(datahub_actions(standalone_mode=False, **kwargs))
2025-02-10 13:13:18     115      except click.exceptions.Abort:
2025-02-10 13:13:18 
2025-02-10 13:13:18 File "/datahub-ingestion/.venv/lib/python3.10/site-packages/click/core.py", line 1161, in __call__
2025-02-10 13:13:18     1159  def __call__(self, *args: t.Any, **kwargs: t.Any) -> t.Any:
2025-02-10 13:13:18  (...)
2025-02-10 13:13:18 --> 1161      return self.main(*args, **kwargs)
2025-02-10 13:13:18 
2025-02-10 13:13:18 File "/datahub-ingestion/.venv/lib/python3.10/site-packages/click/core.py", line 1082, in main
2025-02-10 13:13:18     rv = self.invoke(ctx)
2025-02-10 13:13:18 File "/datahub-ingestion/.venv/lib/python3.10/site-packages/click/core.py", line 1697, in invoke
2025-02-10 13:13:18     return _process_result(sub_ctx.command.invoke(sub_ctx))
2025-02-10 13:13:18 File "/datahub-ingestion/.venv/lib/python3.10/site-packages/click/core.py", line 1697, in invoke
2025-02-10 13:13:18     return _process_result(sub_ctx.command.invoke(sub_ctx))
2025-02-10 13:13:18 File "/datahub-ingestion/.venv/lib/python3.10/site-packages/click/core.py", line 1443, in invoke
2025-02-10 13:13:18     return ctx.invoke(self.callback, **ctx.params)
2025-02-10 13:13:18 File "/datahub-ingestion/.venv/lib/python3.10/site-packages/click/core.py", line 788, in invoke
2025-02-10 13:13:18     return __callback(*args, **kwargs)
2025-02-10 13:13:18 File "/datahub-ingestion/.venv/lib/python3.10/site-packages/click/decorators.py", line 33, in new_func
2025-02-10 13:13:18     return f(get_current_context(), *args, **kwargs)
2025-02-10 13:13:18 File "/datahub-ingestion/.venv/lib/python3.10/site-packages/datahub_actions/cli/actions.py", line 148, in run
2025-02-10 13:13:18     103  def run(ctx: Any, config: List[str], debug: bool) -> None:
2025-02-10 13:13:18  (...)
2025-02-10 13:13:18     144      for pipeline_config_file in valid_configs:
2025-02-10 13:13:18     145          try:
2025-02-10 13:13:18     146              # Now load the full config with variable expansion
2025-02-10 13:13:18     147              pipeline_config_dict = load_config_file(pipeline_config_file)
2025-02-10 13:13:18 --> 148              pipelines.append(pipeline_config_to_pipeline(pipeline_config_dict))
2025-02-10 13:13:18     149          except UnboundVariable as e:
2025-02-10 13:13:18 
2025-02-10 13:13:18 File "/datahub-ingestion/.venv/lib/python3.10/site-packages/datahub_actions/cli/actions.py", line 44, in pipeline_config_to_pipeline
2025-02-10 13:13:18     37   def pipeline_config_to_pipeline(pipeline_config: dict) -> Pipeline:
2025-02-10 13:13:18  (...)
2025-02-10 13:13:18     40       )
2025-02-10 13:13:18     41       try:
2025-02-10 13:13:18     42           return Pipeline.create(pipeline_config)
2025-02-10 13:13:18     43       except Exception as e:
2025-02-10 13:13:18 --> 44           raise Exception(
2025-02-10 13:13:18     45               f"Failed to instantiate Actions Pipeline using config {pipeline_config.get('name')}: {e}"
2025-02-10 13:13:18 
2025-02-10 13:13:18 Exception: Failed to instantiate Actions Pipeline using config datahub_slack_action: Pipeline is disabled, but create method was called unexpectedly.
2025-02-10 13:13:18 [2025-02-10 12:13:18,843] INFO     {datahub_actions.entrypoints:131} - DataHub Actions version: 0.1.9 at /datahub-ingestion/.venv/lib/python3.10/site-packages/datahub_actions/__init__.py
@rospe
Copy link

rospe commented Mar 6, 2025

similar thing happened when I tried to disable the propagation with

    - name: DATAHUB_ACTIONS_DOC_PROPAGATION_ENABLED
      value: "false"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rospe @wgs-jasminkos