Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Configurable consumer_config in DataHub Action Docker Image #166

Open
wornjs opened this issue Feb 4, 2025 · 0 comments
Open

Enable Configurable consumer_config in DataHub Action Docker Image #166

wornjs opened this issue Feb 4, 2025 · 0 comments

Comments

@wornjs
Copy link

wornjs commented Feb 4, 2025

Issue Description
Currently, the executor.yaml configuration in the DataHub Action Docker image only supports plain-text Kafka connections. This limitation prevents connections to Kafka clusters that require SSL/SASL authentication or other advanced configurations.

To enhance compatibility, we should allow users to specify consumer_config dynamically using environment variables. This change will enable DataHub Actions to connect to more secure Kafka environments seamlessly.

Proposed Solution
Modify the Docker image to read environment variables at runtime and generate the executor.yaml file accordingly. The updated configuration should support additional consumer_config parameters based on environment variables.

Example executor.yaml after modification

source:
  type: "kafka"
  config:
    connection:
      bootstrap: ${KAFKA_BOOTSTRAP_SERVER:-localhost:9092}
      schema_registry_url: ${SCHEMA_REGISTRY_URL:-http://localhost:8081}
    topic_routes:
      mcl: ${METADATA_CHANGE_LOG_VERSIONED_TOPIC_NAME:-MetadataChangeLog_Versioned_v1}
      pe: ${PLATFORM_EVENT_TOPIC_NAME:-PlatformEvent_v1}
    consumer_config:
      # Add dynamic consumer config based on environment variables

This approach ensures that users can configure Kafka connections dynamically without modifying the Docker image or manually editing executor.yaml.

Let’s implement this enhancement to improve flexibility and security in DataHub Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant