From 448077e6901e504189db82e4e2ac2d2ec6b36ef0 Mon Sep 17 00:00:00 2001
From: Dane Powell <git@danepowell.com>
Date: Mon, 9 Sep 2024 14:37:32 -0700
Subject: [PATCH] fix release version

---
 .github/workflows/ci.yml    | 2 +-
 bin/acli                    | 2 +-
 src/Command/CommandBase.php | 3 ---
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0b70ecd85..b072bd20a 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -85,7 +85,7 @@ jobs:
           if [[ "$GITHUB_REF_TYPE" == 'tag' ]]; then
             echo "ACLI_VERSION=$GITHUB_REF_NAME" >> $GITHUB_OUTPUT
           else
-            echo "ACLI_VERSION=$GITHUB_SHA" >> $GITHUB_OUTPUT
+            echo "ACLI_VERSION=dev-$GITHUB_REF_NAME" >> $GITHUB_OUTPUT
           fi
       - name: 'Create env file'
         run: |
diff --git a/bin/acli b/bin/acli
index de300a07c..56ea7c2e9 100755
--- a/bin/acli
+++ b/bin/acli
@@ -80,7 +80,7 @@ if (in_array($input->getFirstArgument(), ['clear-kernel-cache', 'ckc'])) {
 
 putenv('BUGSNAG_KEY=');
 putenv('AMPLITUDE_KEY=');
-putenv('ACLI_VERSION=UNKNOWN');
+putenv('ACLI_VERSION=dev-unknown');
 $dotenv = Dotenv::createUnsafeMutable(__DIR__ . '/..');
 $dotenv->safeLoad();
 
diff --git a/src/Command/CommandBase.php b/src/Command/CommandBase.php
index 609d82df3..74806bbe0 100644
--- a/src/Command/CommandBase.php
+++ b/src/Command/CommandBase.php
@@ -1197,9 +1197,6 @@ public function checkForNewVersion(): bool|string
         if (AcquiaDrupalEnvironmentDetector::isAhIdeEnv()) {
             return false;
         }
-        if ($this->getApplication()->getVersion() === 'UNKNOWN') {
-            return false;
-        }
         try {
             if (!$this->selfUpdateManager->isUpToDate()) {
                 return $this->selfUpdateManager->getLatestReleaseFromGithub()['tag_name'];