Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Documentated, but unimplemented feature on deploying to pre-created namespaces feature #2379

Open
fe-ax opened this issue Dec 15, 2023 · 1 comment

Comments

@fe-ax
Copy link

fe-ax commented Dec 15, 2023

Related documentation page: https://runtime-docs.acorn.io/running/namespaces-and-service-accounts#to-verify-

This option does not seem to exist, as the following code always generates a name:

func AssignNamespace(req router.Request, resp router.Response) (err error) {
appInstance := req.Object.(*v1.AppInstance)
cond := condition.Setter(appInstance, resp, v1.AppInstanceConditionNamespace)
defer func() {
cond.Error(err)
// clear the error
err = nil
}()
parts := strings.Split(appInstance.Name, ".")
appInstance.Status.Namespace = name.SafeConcatName(parts[len(parts)-1], appInstance.ShortID())
resp.Objects(appInstance)
return nil
}

@danielhass
Copy link

@fe-ax I ran into this too.

The feature --target-namespace as been removed in v0.8.0 according to the release notes.

The docs page you mentioned is already deleted on the main branch and probably only pending a release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants