Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events Modal Scrollability #172

Open
nishantbalaji opened this issue Jan 10, 2022 · 1 comment
Open

Events Modal Scrollability #172

nishantbalaji opened this issue Jan 10, 2022 · 1 comment

Comments

@nishantbalaji
Copy link
Member

This modal is side scrollable, but it isn't clear that this modal is scrollable. Ideally, a scrollbar (or some other method of signifying the component is scrollable) should be implemented. Additionally, a set image width is applied, but a set image height isn't (as seen by the Winter Census event).

image

Here is how it looks like in the membership portal:
image

I'm not sure which is better looking, but it should be consistent between them.

@leestanley
Copy link
Member

Just realized this issue is the same as #177, technically these aren't "modals", they are just cards. But I do agree that we could standardize these two components and possibly merge them into one as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants