-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline Track Info Editing #7
Comments
Does editing the DB propagate to the ID3 tags of the file? On Tue, Mar 4, 2014 at 3:29 PM, CJS7070 [email protected] wrote:
Cole Gleason |
I think it should not. Editing music is beyond the scope of this. Changing just the database is sufficient for searches and display on the frontends. |
AFAIK it doesn't at the moment, but my biggest concern is searching and display. There are lots of songs in Acoustics right now that don't have titles, and as such you can't find them unless you search for the filename itself or the uploader (not ideal). |
The way song adding is currently implemented, any corrections would be overwritten the next time the song adding routine executes. |
Maybe instead of removing the songs in the directory before readding them as your routine currently has it, store a file hash in the song model and don't add any song files whose hash is already in the database. This would keep any metadata in the database from being replaced. |
If you do something like that, make sure the database has a way to clean itself up. For example, if a user has a song that gets added to the DB and then they modify it locally (or delete it), we don't want to wind up with stale DB entries. |
Issue number conflicts from merging two repos. |
There should be a way for users to edit the database information of songs (to correct song titles, etc.). Information should only be editable by admins and maybe the uploader of the song.
The text was updated successfully, but these errors were encountered: