Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Track Info Editing #7

Open
calvin-shirley opened this issue Mar 4, 2014 · 7 comments
Open

Inline Track Info Editing #7

calvin-shirley opened this issue Mar 4, 2014 · 7 comments

Comments

@calvin-shirley
Copy link
Contributor

There should be a way for users to edit the database information of songs (to correct song titles, etc.). Information should only be editable by admins and maybe the uploader of the song.

@colegleason
Copy link
Member

Does editing the DB propagate to the ID3 tags of the file?

On Tue, Mar 4, 2014 at 3:29 PM, CJS7070 [email protected] wrote:

There should be a way for users to edit the database information of songs
(to correct song titles, etc.). Information should only be editable by
admins and maybe the uploader of the song.

Reply to this email directly or view it on GitHubhttps://github.com//issues/7
.

Cole Gleason
Student, University of Illinois at Urbana-Champaign
Computer Science, Class of 2015
[email protected] | colegleason.com

@zachreizner
Copy link
Member

I think it should not. Editing music is beyond the scope of this. Changing just the database is sufficient for searches and display on the frontends.

@calvin-shirley
Copy link
Contributor Author

AFAIK it doesn't at the moment, but my biggest concern is searching and display. There are lots of songs in Acoustics right now that don't have titles, and as such you can't find them unless you search for the filename itself or the uploader (not ideal).

@kevinwang
Copy link
Member

The way song adding is currently implemented, any corrections would be overwritten the next time the song adding routine executes.

@zachreizner
Copy link
Member

Maybe instead of removing the songs in the directory before readding them as your routine currently has it, store a file hash in the song model and don't add any song files whose hash is already in the database. This would keep any metadata in the database from being replaced.

@nhandler
Copy link
Member

nhandler commented Mar 4, 2014

If you do something like that, make sure the database has a way to clean itself up. For example, if a user has a song that gets added to the DB and then they modify it locally (or delete it), we don't want to wind up with stale DB entries.

@kevinwang
Copy link
Member

Issue number conflicts from merging two repos.

@kevinwang kevinwang reopened this Sep 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants