New AMD IGPU detection in Lilu breaks GCN 5 (Vega) IGPU detection

[VisualEhrmanntraut]

revert it

[ExtremeXT]

+1
AMD Ryzen iGPUs are not detected properly anymore.

[alvindimas05]

I rather commit suicide than commit this update

[EAZYBLACK]

it doesnt boot anymore with this commit on amd ryzen igpu

[vit9696]

Could you please provide more details on what exactly happens on which platforms?

Also, isn't @Zormeister one of your contributors and wasn't the change coordinated with the patches for the drivers?

[vit9696]

references acidanthera/Lilu#97

[alvindimas05]

Could you please provide more details on what exactly happens on which platforms?

Also, isn't @Zormeister one of your contributors and wasn't the change coordinated with the patches for the drivers?

Tested on AMD hack with AMD iGPU and can't boot at all.

[vit9696]

Sorry, but this is not a support forum, but a bugtracker. Here we require more specific information on the issue. IORegistryExplorer dump would be a good start along with the hardware information.

[VisualEhrmanntraut]

@vit9696 That person has left our team since a month ago so these changes were not co-ordinated on our part. These changes make the iGPU not get detected at all (videoBuiltin is null) at least not the Vega (GCN 5) ones.

[vit9696]

Right, will it make sense to revert the change and let you rework the patch as needed if at all?

[VisualEhrmanntraut]

These changes currently only make sense for detecting the older iGPUs and not these ones and their successors, as the current code was working fine. As such, currently, it is not our responsibility to support them. I guess you should revert the changes for now and probably contact Zormeister for further elaboration on what to do for legacy AMD iGPUs on this matter.

[vit9696]

I reverted the change for now. @Zormeister, could you please provide a V2 for the patch so that it does not break the existing setups please?

[Zormeister]

working on fixing it

[vit9696]

@VisualEhrmanntraut, @alvindimas05, @ExtremeXT, @EAZYBLACK, please review acidanthera/Lilu#98.

[alvindimas05]

@VisualEhrmanntraut, @alvindimas05, @ExtremeXT, @EAZYBLACK, please review acidanthera/Lilu#98.

Alright, it's working for me now.

[Zormeister]

i confirmed that this also works on my own machine, i didn't deploy the V1 builds to it, only to the Legacy system originally.

[Vuxoni]

Working on my machine too, without problems.

[Sooly890]

Working on my machine, no issues.