Increase visibility of the full tool list link #1409 #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hopefully, better now. If you still find query sub-optimal I can cache. |
prioux
reviewed
Jan 21, 2025
| @@ -46,6 +46,15 @@ def welcome #:nodoc: | |||
| @default_data_provider = DataProvider.find_by_id(current_user.meta["pref_data_provider_id"]) | |||
| @default_bourreau = Bourreau.find_by_id(current_user.meta["pref_bourreau_id"]) | |||
|
|
|||
| @tool_count = Tool | |||
There was a problem hiding this comment.
This expression returns a completely different number of tools compared to current_user.available_tools (which is used in the page to generate the table). In fact, right now my page says "out of 50" and yet the table lists 161 tools.
I think this should be changed to "@tool_names =" to generate a list of names, not just a count, and then the array_to_table in the page should use that array too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1409 for details.