Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDB_BVL_Instrument] addHourMinElement missing yellow warning on status selection #9541

Open
skarya22 opened this issue Jan 21, 2025 · 0 comments · May be fixed by #9555
Open

[NDB_BVL_Instrument] addHourMinElement missing yellow warning on status selection #9541

skarya22 opened this issue Jan 21, 2025 · 0 comments · May be fixed by #9555
Assignees
@skarya22
Labels
Difficuly: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...)

Comments

@skarya22
Copy link
Contributor

Describe the bug

  • The NDB_BVL_Instrument class addHourMinElement does not include a line that adds validation for the following behaviour when a status is selected
Image - HourMinElements do not have the yellow warning, while other elements do. The screenshot is of CCNA with an override that fixes it

Need to add ['class' => 'form-control input-sm not-answered'] as the fourth argument to $this->createSelect
@skarya22 skarya22 added the Difficuly: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...) label Jan 21, 2025
@skarya22 skarya22 self-assigned this Jan 21, 2025
@skarya22 skarya22 linked a pull request Feb 10, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skarya22 skarya22

Labels
Difficuly: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NDB_BVL_Instrument] addHourMin Warning skarya22/Loris
1 participant
@skarya22