Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Implement LorisInstance in tools directory #8058

Open
CamilleBeau opened this issue Mar 18, 2022 · 5 comments · May be fixed by #9397
Open

[tools] Implement LorisInstance in tools directory #8058

CamilleBeau opened this issue Mar 18, 2022 · 5 comments · May be fixed by #9397
Assignees
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@CamilleBeau
Copy link
Contributor

Describe the bug
Plenty of tools were failing because they had not been updated to pass a LorisInstance as an argument to various functions.

The following tools were failing:
delete_ignored_conflicts.php
detect_conflicts.php
lorisform_parser.php
lorisform_parser.php
score_instrument.php

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

  1. Run the above tools as intended
  2. See error
@CamilleBeau CamilleBeau added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Mar 18, 2022
@CamilleBeau
Copy link
Contributor Author

For some reason i'm not able to edit the description properly, but fix_candidate_age.php should also be on this list instead of lorisform_parser.php twice.

@CamilleBeau CamilleBeau added the Critical to release PR or issue is key for the release to which it has been assigned label Mar 22, 2022
@driusan driusan removed the Critical to release PR or issue is key for the release to which it has been assigned label Mar 23, 2022
@driusan
Copy link
Collaborator

driusan commented Mar 23, 2022

the critical ones were fixed, but there's still some other ones that need to be fixed according to @CamilleBeau.. @CamilleBeau can you give a list of which are outstanding?

@CamilleBeau
Copy link
Contributor Author

the critical ones were fixed, but there's still some other ones that need to be fixed according to @CamilleBeau.. @CamilleBeau can you give a list of which are outstanding?

delete_ignored_conflicts.php
detect_conflicts.php

@CamilleBeau
Copy link
Contributor Author

I believe this has been resolved for the 2 scripts above - I will test before EOD

@CamilleBeau
Copy link
Contributor Author

Nevermind, still an issue for both:

(base) lorisadmin@cbeaudoin-dev:/var/www/loris/tools/data_integrity/data_deletion$ php delete_ignored_conflicts.php confirm
PHP Warning: Undefined variable $loris in /var/www/loris/tools/data_integrity/data_deletion/delete_ignored_conflicts.php on line 72
PHP Fatal error: Uncaught TypeError: NDB_BVL_Instrument::getDDEInstrumentNamesList(): Argument #1 ($loris) must be of type LORIS\LorisInstance, null given, called in /var/www/loris/tools/data_integrity/data_deletion/delete_ignored_conflicts.php on line 72 and defined in /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc:3253
Stack trace:
#0 /var/www/loris/tools/data_integrity/data_deletion/delete_ignored_conflicts.php(72): NDB_BVL_Instrument::getDDEInstrumentNamesList()
#1 {main}
thrown in /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc on line 3253

(base) lorisadmin@cbeaudoin-dev:/var/www/loris/tools$ php detect_conflicts.php -r all -y
Array
(
[r] => all
[y] =>
)
Removing ignored conflicts

PHP Fatal error: Uncaught TypeError: NDB_BVL_Instrument::factory(): Argument #1 ($loris) must be of type LORIS\LORISInstance, string given, called in /var/www/loris/tools/detect_conflicts.php on line 593 and defined in /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc:225
Stack trace:
#0 /var/www/loris/tools/detect_conflicts.php(593): NDB_BVL_Instrument::factory()
#1 /var/www/loris/tools/detect_conflicts.php(145): detectIgnoreColumns()
#2 {main}
thrown in /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc on line 225

@CamilleBeau CamilleBeau assigned victori444 and unassigned racostas Sep 24, 2024
@victori444 victori444 linked a pull request Oct 8, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
Status: PR sent
Development

Successfully merging a pull request may close this issue.

4 participants