Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

incompatible with uglifyjs #20

Open
evgenyfadeev opened this issue Nov 28, 2018 · 8 comments
Open

incompatible with uglifyjs #20

evgenyfadeev opened this issue Nov 28, 2018 · 8 comments

Comments

@evgenyfadeev
Copy link

Hello, I'm getting this when building the productio package

....... from UglifyJs
Unexpected token: punc (,) ....

Perhaps there is a way to add build configuration to the package to fix this?
I've gone around by copying the code in my utilities library.
Thanks!

@aceakash
Copy link
Owner

Don't know enough about Uglify, sorry. Does it support ES6? That might be the difference.
Try using the latest version 1.x of string-similarity which is ES5 to verify.

@evgenyfadeev
Copy link
Author

uglify does not support es6, so I thought you might add a build config to transpile the code to es5...

@aceakash
Copy link
Owner

Fair enough @evgenyfadeev, I'm open to any PRs for build config.

@aceakash aceakash reopened this Nov 30, 2018
@janriemer
Copy link

@aceakash @evgenyfadeev
Actually, terser supports minification of ES6. 👌
I've used it with rollup in scrolldir-observable.

@balazsorban44
Copy link

From terser

Why choose terser?
uglify-es is no longer maintained and uglify-js does not support ES6+.
terser is a fork of uglify-es that retains API and CLI compatibility with uglify-es and uglify-js@3.

@sitch
Copy link

sitch commented Mar 15, 2019

bump

@ljmerza
Copy link

ljmerza commented Jan 9, 2020

es6 has been out for almost 5 years. why go through the trouble of supporting uglify-js? don't enable outdated code.

@janriemer
Copy link

Isn't this PR adding support for ES6 with babel? Can it be merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants