New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authorization in views #47

Open

b1rger opened this issue Nov 22, 2023 · 0 comments

Contributor

b1rger commented Nov 22, 2023

apis-bibsonomy/apis_bibsonomy/views.py

Line 63 in c1279fa

return super().form_invalid(form)

Comment from @sennierer in #36

This doesnt look right. Form validation should only need to fail if the content sent within the form is not valid. If the user is not authenticated and thus not allowed to do that there should be a return HttpResponse('Unauthorized', status=401) returned. However, I guess that should be raised/returned in the dispatch function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment