From c314efa822d1a2a161de412fe82b2dfe8fb734ff Mon Sep 17 00:00:00 2001 From: Andrea Titton Date: Mon, 11 Mar 2019 16:32:16 +0100 Subject: [PATCH 1/3] =?UTF-8?q?=F0=9F=92=84=20setted=20eslint=20rule?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/eslint-config-accurapp/index.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/eslint-config-accurapp/index.js b/packages/eslint-config-accurapp/index.js index 06e57f57..0c0e6e91 100644 --- a/packages/eslint-config-accurapp/index.js +++ b/packages/eslint-config-accurapp/index.js @@ -138,5 +138,8 @@ module.exports = { // disable eslint-plugin-node rules because they error 'node/no-deprecated-api': 'off', 'node/process-exit-as-throw': 'off', + + // disable generator-star-spacing due to conflict with prettier, see https://github.com/accurat/accurapp/issues/51 + 'generator-star-spacing': 'off', }, } From 0c39111e911a089c1e5a8c73cac8d6de8f7a4f14 Mon Sep 17 00:00:00 2001 From: Andrea Titton Date: Mon, 11 Mar 2019 17:17:16 +0100 Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=92=84=20fixed=20according=20to=20com?= =?UTF-8?q?ment?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/eslint-config-accurapp/index.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/eslint-config-accurapp/index.js b/packages/eslint-config-accurapp/index.js index 0c0e6e91..4257ae02 100644 --- a/packages/eslint-config-accurapp/index.js +++ b/packages/eslint-config-accurapp/index.js @@ -139,7 +139,7 @@ module.exports = { 'node/no-deprecated-api': 'off', 'node/process-exit-as-throw': 'off', - // disable generator-star-spacing due to conflict with prettier, see https://github.com/accurat/accurapp/issues/51 - 'generator-star-spacing': 'off', + // aligned to prettier, see https://github.com/accurat/accurapp/issues/51 + 'generator-star-spacing': ['warn', 'after'], }, } From a67186c1a92953869705c909e7a7c74e4d7d2809 Mon Sep 17 00:00:00 2001 From: Andrea Titton Date: Mon, 11 Mar 2019 17:22:49 +0100 Subject: [PATCH 3/3] =?UTF-8?q?=F0=9F=92=84fugaro=20nazism?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/eslint-config-accurapp/index.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/eslint-config-accurapp/index.js b/packages/eslint-config-accurapp/index.js index 4257ae02..d9df42de 100644 --- a/packages/eslint-config-accurapp/index.js +++ b/packages/eslint-config-accurapp/index.js @@ -111,6 +111,8 @@ module.exports = { 'react/jsx-props-no-multi-spaces': 'warn', 'promise/no-callback-in-promise': 'warn', 'promise/no-return-wrap': 'warn', + // aligned to prettier, see https://github.com/accurat/accurapp/issues/51 + 'generator-star-spacing': ['warn', 'after'], // ERRORS 'no-redeclare': 'error', @@ -138,8 +140,5 @@ module.exports = { // disable eslint-plugin-node rules because they error 'node/no-deprecated-api': 'off', 'node/process-exit-as-throw': 'off', - - // aligned to prettier, see https://github.com/accurat/accurapp/issues/51 - 'generator-star-spacing': ['warn', 'after'], }, }