Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README outdated: suggested SASS configuration doesn't work #50

Closed
NoFishLikeIan opened this issue Mar 8, 2019 · 4 comments · Fixed by #52
Closed

README outdated: suggested SASS configuration doesn't work #50

NoFishLikeIan opened this issue Mar 8, 2019 · 4 comments · Fixed by #52
Assignees
@ivanross

Comments

@NoFishLikeIan
Copy link

The configuration described here gives now an error:

https://github.com/accurat/accurapp#customizing-webpack

const { buildWebpackConfig } = require('webpack-preset-accurapp')
const { sass } = require('webpack-blocks')

module.exports = buildWebpackConfig([
  sass(),
])
@marcofugaro
Copy link
Contributor

const { sass } = require('webpack-blocks')

becomes

const { sass } = require('@webpack-blocks/sass')

can you make a PR?

@ivanross
Copy link
Contributor

ivanross commented Mar 8, 2019 

const { buildWebpackConfig } = require('webpack-preset-accurapp')
const { match } = require('@webpack-blocks/webpack')
const { css } = require('@webpack-blocks/assets')
const sass = require('@webpack-blocks/sass')

module.exports = buildWebpackConfig([
  match(['*.scss'], [css(cssOptions), postcss(postcssOptions), sass()]),
])

@NoFishLikeIan
Copy link
Author

@ivanross I'll assign you to it.

@marcofugaro
Copy link
Contributor

@ivanross yes, also the cssOptions and postcssOptions should be made exportable like this

const { buildWebpackConfig, cssOptions, postcssOptions } = require('webpack-preset-accurapp')

@ivanross ivanross mentioned this issue Mar 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanross ivanross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix readme sass example and cssOptions and postcssOptions exportable accurat/accurapp
3 participants
@marcofugaro @ivanross @NoFishLikeIan