BaseModelManager filter method, edits AST in place

[ekarademir]

Bug Report 🐛

BaseModelManager filter operation inadvertently manipulates the AST of any model file in place but then also returns a new filtered model manager. It should do one of them, not both.

This causes a problem, if the model ASTs are kept in memory and reused. Because the operation manipulates those objects in memory without advertising it.

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce

1. Create several models that depend on each other in memory
2. Apply a filter operation that would result in removal of imports
3. Inspect the models in memory

Context (Environment)

Desktop

• OS: [e.g. macOS]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 0.22.15]

Detailed Description

Possible Implementation