Skip to content

Latest commit

 

History

History
27 lines (21 loc) · 922 Bytes

code-review.md

File metadata and controls

27 lines (21 loc) · 922 Bytes

#Code Review Format

1. Programmer demos program

2. Programmer walks through the code

  1. High level description of what the program should accomplish
  2. Talk about the structure of your program
  • Why did you make certain design decisions?
  1. Talk about issues you ran into while writing your program
  • What did you learn?
  • What did you compromise on?
  • If you were to keep working on this, what would you change/improve?
    • How would you change your implementation?
    • What functionality would you add?

3. Collective code review

  1. Guide the discussion
  • Ask if you've explained the code sufficiently?
  • Is something missing?
  • Ask if anyone can think of failure scenarios?
  1. Constructive Criticism (5min)
  • Anyone can discuss any aspect of the code

Code review rules:

When reviewing someone else’s code, please keep your feedback ACTIONABLE, SPECIFIC, and KIND.