Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric filters do not persist through refiltering/sorting #13

Open
abreal-badger opened this issue Jan 13, 2022 · 1 comment
Open

Numeric filters do not persist through refiltering/sorting #13

abreal-badger opened this issue Jan 13, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@abreal-badger
Copy link
Owner

The filters that Follicule applies for numeric values (kudos, chapters, comments, bookmarks, hits) are lost if, at some future point, the Sort and Filter button is clicked, which is a possibility if a filter is applied, the page is filtered, and then an additional filter term is added.

This appears to be an issue with how search terms are re-applied in the 'search within results' box on a new page load: manually entering a term like kudos>1000 in the SWR box and clicking Sort and Filter results in the same behavior: the resulting search results doesn't have the term in the SWR box.

tl;dr: this is an issue with Ao3's filtering, and I don't have a good workaround for the overall problem.

@abreal-badger abreal-badger added the bug Something isn't working label Jan 13, 2022
@abreal-badger
Copy link
Owner Author

Solutions and workarounds:

Short term, apply numeric filters as the last thing you do.

Middle term, a partial interim fix might include taking the wordcount follicule and directing it to the wordcount filter boxes, as those propagate values when refiltering.

Longer term, this might integrate with issue #2 , where a workaround might involve reading the URL params and re-integrating the missing search terms into the filter UI/SWR box to allow them to propagate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant