Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On connect queued messages are sent before attaching channels #902

Open
davyskiba opened this issue Jan 23, 2023 · 4 comments
Open

On connect queued messages are sent before attaching channels #902

davyskiba opened this issue Jan 23, 2023 · 4 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@davyskiba
Copy link
Contributor

When a connection enters the connected state, queued messages are sent first, and channels are attached afterward. This behavior matches the in ConnectionManager.. It can lead to unexpected exceptions i.e. when queued presence leave message is sent before channel reattach like documented in this AAT issue.

@davyskiba davyskiba added the bug Something isn't working. It's clear that this does need to be fixed. label Jan 23, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Jan 23, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3269

@paddybyers
Copy link
Member

There should only be queued messages for channels that were attached at the time they were sent.

If it's a reconnection that's a failed resume, then channels should be reattached before queued messages are sent.

@ikbalkaya
Copy link
Contributor

@davyskiba Is it easy to replicate this in AAT repo 🤔 I'd like to test this against some changes I made recently.

@ikbalkaya
Copy link
Contributor

So I had a run with the test locally against ably-java version with changes done #900
the test passes and it fixes this issue. After confirmed collectively, we should close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

No branches or pull requests

3 participants