Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHA-RC1] Implement async rooms.get and rooms.release #51

Open
sacOO7 opened this issue Nov 12, 2024 · 0 comments
Open

[CHA-RC1] Implement async rooms.get and rooms.release #51

sacOO7 opened this issue Nov 12, 2024 · 0 comments
Assignees

Comments

@sacOO7
Copy link

sacOO7 commented Nov 12, 2024

  • Implement async rooms.get('roomId') and rooms.release('roomId') operations as per spec and rooms async DR
  • The current rooms.get operation is blocking in nature, this needs to be updated to async in nature as per rooms get async chat-js PR
  • This affects how internal room-lifecycle-manager works and has been implemented accordingly.
  • Reference impl. for the same ->
  1. getRoom -> https://github.com/ably/ably-chat-js/blob/54229a40a8b2a506f36ffbb5e3a355c2e2616199/src/core/rooms.ts#L145
  2. releaseRoom -> https://github.com/ably/ably-chat-js/blob/54229a40a8b2a506f36ffbb5e3a355c2e2616199/src/core/rooms.ts#L156

┆Issue is synchronized with this Jira Task by Unito

@sacOO7 sacOO7 self-assigned this Nov 12, 2024
@sacOO7 sacOO7 changed the title [CHA-RC1][CHA-RC2] Room configuration, update rooms.get and rooms.release [CHA-RC1] Implement async rooms.get and rooms.release Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant