From f34b28e932f8c4f8d04f5bf89ae61078be3525fd Mon Sep 17 00:00:00 2001 From: Bartek Palak Date: Tue, 5 Mar 2013 15:35:02 +0100 Subject: [PATCH] Vulnerabilities corrections Making static field final to protect them from malicious changes --- gridftp/src/main/java/org/globus/ftp/dc/AsciiTranslator.java | 2 +- .../src/main/java/org/globus/gsi/TrustedCertificates.java | 2 +- ssl-proxies/src/main/java/org/globus/util/PEMUtils.java | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gridftp/src/main/java/org/globus/ftp/dc/AsciiTranslator.java b/gridftp/src/main/java/org/globus/ftp/dc/AsciiTranslator.java index 381de5ca..16892809 100755 --- a/gridftp/src/main/java/org/globus/ftp/dc/AsciiTranslator.java +++ b/gridftp/src/main/java/org/globus/ftp/dc/AsciiTranslator.java @@ -32,7 +32,7 @@ public class AsciiTranslator { protected byte[] lineSep; - protected static byte[] systemLineSep; + protected final static byte[] systemLineSep; static { systemLineSep = System.getProperty("line.separator").getBytes(); diff --git a/ssl-proxies/src/main/java/org/globus/gsi/TrustedCertificates.java b/ssl-proxies/src/main/java/org/globus/gsi/TrustedCertificates.java index dab78d1b..c9994143 100644 --- a/ssl-proxies/src/main/java/org/globus/gsi/TrustedCertificates.java +++ b/ssl-proxies/src/main/java/org/globus/gsi/TrustedCertificates.java @@ -85,7 +85,7 @@ public class TrustedCertificates implements Serializable { * .signing_policy in the same directory as the trusted * certificates. */ - public static String SIGNING_POLICY_FILE_SUFFIX = ".signing_policy"; + public final static String SIGNING_POLICY_FILE_SUFFIX = ".signing_policy"; private static KeyStore ms_trustStore = null; private static CertStore ms_crlStore = null; diff --git a/ssl-proxies/src/main/java/org/globus/util/PEMUtils.java b/ssl-proxies/src/main/java/org/globus/util/PEMUtils.java index 6c5e5b3c..3c78febd 100644 --- a/ssl-proxies/src/main/java/org/globus/util/PEMUtils.java +++ b/ssl-proxies/src/main/java/org/globus/util/PEMUtils.java @@ -21,8 +21,8 @@ public class PEMUtils { static final int LINE_LENGTH = 64; - public static String lineSep; - public static byte[] lineSepBytes; + public final static String lineSep; + public final static byte[] lineSepBytes; static { lineSep = System.getProperty("line.separator");