Skip to content

branch submit: better error message if base hasn't been submitted #460

Closed
@abhinav

Description

@abhinav

When base branch is non-trunk, but hasn't been submitted, GitHub will reject the submission in gs branch submit because it doesn't know the base ref and won't see any commits between base and head.

The error takes the form:

Head sha can't be blank, Base sha can't be blank, No commits between [...] and [...], Base ref must be a branch

gs branch submit should confirm that non-trunk base has been submitted before it submits the current branch, while still allowing for --no-publish for non-GitHub workflows.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/forgeIssues heavy on dealing with Forges.bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions