Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding labels when creating PRs on github #414

Open
xocasdashdash opened this issue Sep 18, 2024 · 1 comment
Open

Adding labels when creating PRs on github #414

xocasdashdash opened this issue Sep 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@xocasdashdash
Copy link

Our CI requires that some labels be present to work correctly.

How do you feel about adding a comma separated list of labels to the when submitting a branch? in my case it's ok to fail if the labels are not present

@abhinav abhinav added the enhancement New feature or request label Sep 18, 2024
@abhinav
Copy link
Owner

abhinav commented Sep 18, 2024

This makes sense. It was amongst the "when we need it" features.
I'll try to get to this when I have the time.

The rough shape of this, if you'd like to take a stab at this:

There may be some nuance to the forge.Repository contract because, I suspect, GitHub labels have to be created before being used, and they're probably not idempotent, and we don't want to make too many extraneous requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants