Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsk.penWidth() seems to be broken #416

Closed
ademuri opened this issue Dec 25, 2023 · 2 comments · Fixed by #419
Closed

vsk.penWidth() seems to be broken #416

ademuri opened this issue Dec 25, 2023 · 2 comments · Fixed by #419

Comments

@ademuri
Copy link
Contributor

ademuri commented Dec 25, 2023

I'm running vsk version 1.0.0, on Ubuntu 20.04.

It appears that calling vsk.penWidth() does not work. I tried using it in a simple sketch, but calling it with various values did not change anything. Setting the default pen width in the menu in the vsk gui worked fine.

For a reproducible test case, I loaded the shape_basic example, which calls vsk.penWidth("2mm", 3). This also does not produce any discernible change, either in vsk run or vsk save.

I've attached exported svgs, using like: sketch_shape_basic_liked_1

and vsk save:
sketch_shape_basic_vsk_save

@abey79
Copy link
Owner

abey79 commented Jan 7, 2024

I can reproduce. It seems that the Override setting is broken: the path width is overridden regardless of the Override setting in the viewer.

@abey79
Copy link
Owner

abey79 commented Jan 8, 2024

Nvm. I just never vsketch's penWidth to vpype's metadata (which was introduced later on). vsk.penWidth is currently used for fill hatching and other, but not displayed. This is basically a duplicate of #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants