Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inlined Markdown #65

Open
saurabhdaware opened this issue Aug 16, 2020 · 4 comments
Open

Inlined Markdown #65

saurabhdaware opened this issue Aug 16, 2020 · 4 comments
Labels
Draft Draft idea. Not sure what I am doing with my life enhancement New feature or request future plan We will explore this in future Idea A random idea before actually putting it out in code

Comments

@saurabhdaware
Copy link
Member

Describe the solution you'd like

<html>
 <body>
   <h2>About Me</h2>
   <AbellMarkdown>
     Hi, I am **Saurabh**. I love making websites. 
     You can follow me on [Twitter at saurabhcodes](https://twitter.com/saurabhcodes)
   </AbellMarkdown>
</body>
</html>
@saurabhdaware saurabhdaware added enhancement New feature or request Idea A random idea before actually putting it out in code Draft Draft idea. Not sure what I am doing with my life labels Aug 16, 2020
@saurabhdaware
Copy link
Member Author

Dropping it here for future reference

<AbellMarkdown source="../content/index.md" />

suggested by @anuraghazra on Discord

@anuraghazra
Copy link
Contributor

Maybe also directly fetch the content by passing an url :-

<AbellMarkdown fetch="https://md.com" />

or with the same prop

<AbellMarkdown source="https://md.com" />

@saurabhdaware
Copy link
Member Author

saurabhdaware commented Sep 21, 2020 •
edited
Loading

I think we should call it path instead of source and URLs may cause confusion. Here's why:
In HTML, when we use, <img src="./hello.jpg"/> and then change the hello.jpg image, it changes in the website.
But in abell, if we say

<AbellMarkdown source="https://example.com/myblog.md" />

and then make changes in markdown file and push it. It won't change in Abell's website since it needs a rebuild and the source is only read during the abell build

So I think, for now, we can leave URL markdowns to be handled by source plugins since that syntax may push users to link external markdown files and expect them to change when the markdown is changed.

@saurabhdaware saurabhdaware added the future plan We will explore this in future label Sep 28, 2020
@saurabhdaware
Copy link
Member Author

We can fix this after abelljs/abell-renderer#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Draft Draft idea. Not sure what I am doing with my life enhancement New feature or request future plan We will explore this in future Idea A random idea before actually putting it out in code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saurabhdaware @anuraghazra