Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor commenting strategies for better reusability #355

Open
verbanicm opened this issue Aug 6, 2024 · 0 comments
Open

Refactor commenting strategies for better reusability #355

verbanicm opened this issue Aug 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@verbanicm
Copy link
Contributor

TL;DR

Current commenting strategies in the plan and apply commands duplicate code frequently.

Detailed design

Two options top of mind:

1) We can create helper functions to generate the different types of messages (e.g. https://github.com/abcxyz/guardian/pull/352#discussion_r1704680358)

2) We can create a reporter/commenter interface and implement it for github to allow for potential future strategies. The interface would require methods for generating the different messages and writing them to the output (github, stdout, etc)

Alternatives considered

No response

Additional information

No response

@verbanicm verbanicm added the enhancement New feature or request label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant