Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to import utils #1

Open
JiuhaiChen opened this issue Oct 13, 2023 · 3 comments
Open

unable to import utils #1

JiuhaiChen opened this issue Oct 13, 2023 · 3 comments

Comments

@JiuhaiChen
Copy link

Hi, thanks for releasing the codebase, it's really helpful. It seems that i am unable to import utils, for example, from utils import save_in_jsonl, distinctness, load_from_picklein data_cleaning.py, save_in_jsonl, distinctness, load_from_pickle should be under utils.utils? the same problem for other file. And i am unable to save "eval_cache.pkl" in the data_cleaning.py, can you check the issue? thanks!

@abaheti95
Copy link
Owner

Thank you for pointing them out. I updated the imports in the big model training files. Please let me know if there are still any other issues.

@JiuhaiChen
Copy link
Author

JiuhaiChen commented Oct 15, 2023

Thanks for fixing it. There are some issues for data_cleaning.py, cannot find "eval_cache.pkl", if i skip it, when i do the training procedure, it cannot find the cleaner_train.json under folderdata/hh_train_len2/.

One more question, have you tried full model finetuning instead of lora ?

@abaheti95
Copy link
Owner

Hi @JiuhaiChen ,
Thank you for helping me debug this. Seems like there was a lot of redundant code in the data_cleaning.py file. I removed it and uncommented the lines which do the saving of the cleaned data.

Regarding the full-finetuning: No, I haven't tried full-finetuning mainly because I wanted to use priority sampling in A-LoL which is not trivial to do with deepspeed and trainer. I will get to that at some point in the future but not right now.

Feel free to add more follow-up questions in case you still struggle to run the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants