Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent stETH from being used with collateral swap and repay with collateral #1365

Closed
grothem opened this issue Dec 15, 2022 · 1 comment
Closed

Prevent stETH from being used with collateral swap and repay with collateral #1365

grothem opened this issue Dec 15, 2022 · 1 comment
Labels
bug Something isn't working new issue This issue has not been triaged by the core team yet

Comments

@grothem
Copy link
Collaborator

grothem commented Dec 15, 2022

Describe the bug
Due to the possibility of a 2 wei precision error in the stETH contract when calling balanceOf, collateral swap and repay collateral will not work when trying to use stETH. We currently are only showing an error message if a flash loan is going to be used, but this needs to be expanded and we should show the error if the user selects stETH to swap/repay with.

Additional context
See lidofinance/lido-dao#442 for more details
@grothem grothem added bug Something isn't working new issue This issue has not been triaged by the core team yet labels Dec 15, 2022
@defispartan defispartan mentioned this issue Dec 16, 2022
Closed
17 tasks
@drewcook drewcook reopened this Jan 12, 2023
@grothem
Copy link
Collaborator Author

grothem commented Feb 22, 2023

closed by #1474

@grothem grothem closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working new issue This issue has not been triaged by the core team yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drewcook @grothem