Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobufCodeGenPlugins strips everything after colon in Windows filenames #23

Open
ejona86 opened this issue Mar 2, 2015 · 0 comments

Comments

@ejona86
Copy link

ejona86 commented Mar 2, 2015

Say you have something like:

protobufCodeGenPlugins = ["my-plugin:$buildDir/some/path"]

If buildDir on Windows starts with C:, the command passed to protoc will be:

--plugin=protoc-gen-my-plugin=C

It seems that some it.split(":") should be it.split(":", 2) in order to avoid stripping the rest of the path, but I had trouble testing the change to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant