-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-on gestures: convert gestures map into script decorator functions #73
Comments
Hi, Optionally, I may need to fix grammar issues found in input help messages for some scripts, but I won't do it as it will cause problems for translators in the short term. Thanks. |
Hi Joseph,
Go with the grammar fixing, as translators will benefit from this.
It’s time to fix French grammar in English, as some users told me that there were a lot of errors in the languages I maintain.
From: Joseph Lee <[email protected]>
Sent: Thursday, July 16, 2020 7:24 PM
To: Andre9642/BrailleExtender <[email protected]>
Cc: Subscribed <[email protected]>
Subject: Re: [Andre9642/BrailleExtender] Add-on gestures: convert gestures map into script decorator functions (#73)
Hi,
Optionally, I may need to fix grammar issues found in input help messages for some scripts, but I won't do it as it will cause problems for translators in the short term.
Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#73 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACVCDE7ORE3SHLVVHH5H6HTR34ZSFANCNFSM4O4TYZNQ> . <https://github.com/notifications/beacon/ACVCDE65NAIZS3GAOPT6F6TR34ZSFA5CNFSM4O4TYZN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE5IANIQ.gif>
|
Hi, I’ll do that as part of a separate pull request (not this one yet). Thanks.
From: zstanecic <[email protected]>
Sent: Thursday, July 16, 2020 10:36 AM
To: Andre9642/BrailleExtender <[email protected]>
Cc: Joseph Lee <[email protected]>; Author <[email protected]>
Subject: Re: [Andre9642/BrailleExtender] Add-on gestures: convert gestures map into script decorator functions (#73)
Hi Joseph,
Go with the grammar fixing, as translators will benefit from this.
It’s time to fix French grammar in English, as some users told me that there were a lot of errors in the languages I maintain.
From: Joseph Lee <[email protected]>
Sent: Thursday, July 16, 2020 7:24 PM
To: Andre9642/BrailleExtender <[email protected]>
Cc: Subscribed <[email protected]>
Subject: Re: [Andre9642/BrailleExtender] Add-on gestures: convert gestures map into script decorator functions (#73)
Hi,
Optionally, I may need to fix grammar issues found in input help messages for some scripts, but I won't do it as it will cause problems for translators in the short term.
Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#73 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACVCDE7ORE3SHLVVHH5H6HTR34ZSFANCNFSM4O4TYZNQ> . <https://github.com/notifications/beacon/ACVCDE65NAIZS3GAOPT6F6TR34ZSFA5CNFSM4O4TYZN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE5IANIQ.gif>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#73 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEBVLLAMEJE3663KWRTR3426NANCNFSM4O4TYZNQ> .
|
This was referenced Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Continuing code refactoring, this time code modernization:
In 2018, scriptHandler.script decorator was introduced, allowing add-on developers to specify gestures, input help messages, and categories for a script in one place. In case of Braille Extender add-on, using script decorator modernizes the add-on. It also has another benefit: it removes use of OrderedDict when defining gestures, as Python 3.7 guarantees insertion order for dictionaries (this may involve either removing gestures map or rearranging methods in the global plugin class to preserve original gestures map order).
Thanks.
The text was updated successfully, but these errors were encountered: