feat: add support for setting float parameters

Author: dotconnor

lib/driveweb.js

@@ -37,11 +37,12 @@ function DriveInterface(ip, config) {
   this.ip = ip;
   this.port = 48556;
   this.PROTOCOL_DEVICE = 0x81;
-  this.LEN_WRAPPER = 4;
+  this.LEN_WRAPPER = 0x04;
   this.REQ_GET = 0x84;
-  this.LEN_GET = 4;
+  this.LEN_GET = 0x04;
   this.REQ_SET = 0x86;
-  this.LEN_SET = 6;
+  this.LEN_FLOAT_SET = 0x08;
+  this.LEN_SET = 0x06;
   this.EX_TYPE = 0xff;
   this.EX_LOCK_FAIL = 0xff;
   this.EX_LOCK_TIMEOUT = 0xfe;
@@ -62,14 +63,7 @@ function DriveInterface(ip, config) {
   return this;
 }
 
-DriveInterface.prototype.getParameter = async function getParameter(
-  paramId,
-  pure
-) {
-  if (Array.isArray(paramId)) {
-    return this.getParameters(paramId);
-  }
-
+async function _getParameter(paramId, pure) {
   const data = Buffer.alloc(this.LEN_WRAPPER + this.LEN_GET);
   data[3] = this.PROTOCOL_DEVICE;
   data[4] = this.LEN_GET;
@@ -84,6 +78,31 @@ DriveInterface.prototype.getParameter = async function getParameter(
 
   const n = Buffer.from([rslt[6], rslt[7]]);
   return n.readInt16BE();
+}
+
+DriveInterface.prototype.getParameter = async function getParameter(
+  paramId,
+  pure
+) {
+  if (Array.isArray(paramId)) {
+    return this.getParameters(paramId);
+  }
+
+  let retry = 3;
+  let v;
+  while (retry !== 0) {
+    try {
+      return await _getParameter.bind(this)(paramId, pure);
+    } catch (e) {
+      retry = retry - 1;
+    }
+  }
+
+  if (v) {
+    return v;
+  }
+
+  throw new SocketTimeout();
 };
 
 DriveInterface.prototype.getParameters = function getParameters(paramIds) {
@@ -98,10 +117,7 @@ DriveInterface.prototype.getParameters = function getParameters(paramIds) {
   return new Promise((resolve) => resolve(null));
 };
 
-DriveInterface.prototype.setParameter = async function setParameter(
-  paramId,
-  value
-) {
+async function _setParameter(paramId, value) {
   if (paramId !== null && typeof paramId === `object`) {
     return this.setParameters(paramId);
   }
@@ -117,12 +133,32 @@ DriveInterface.prototype.setParameter = async function setParameter(
   v.writeInt16BE(value);
   [data[8], data[9]] = v;
   await this.deviceTransaction(data);
-  const t = await this.getParameter(paramId);
-  if (t !== value) {
-    throw new Error(`Value not set.`);
+  return undefined;
+}
+
+DriveInterface.prototype.setParameter = async function setParameter(
+  paramId,
+  value
+) {
+  if (paramId !== null && typeof paramId === `object`) {
+    return this.setParameters(paramId);
   }
 
-  return t;
+  let retry = 3;
+  let v;
+  while (retry !== 0) {
+    try {
+      return await _setParameter.bind(this)(paramId, value);
+    } catch (e) {
+      retry = retry - 1;
+    }
+  }
+
+  if (v) {
+    return v;
+  }
+
+  throw new SocketTimeout();
 };
 
 DriveInterface.prototype.setParameters = function setParameters(obj) {
@@ -145,6 +181,38 @@ DriveInterface.prototype.getFloatParameter = async function getFloatParameter(
   return n.readFloatBE();
 };
 
+async function _setFloatParameter(paramId, value) {
+  const data = Buffer.alloc(this.LEN_WRAPPER + this.LEN_FLOAT_SET);
+  data[3] = this.PROTOCOL_DEVICE;
+  data[4] = this.LEN_FLOAT_SET;
+  data[5] = this.REQ_SET;
+  data.writeUInt16BE(paramId, 6);
+  data.writeFloatBE(value, 8);
+  await this.deviceTransaction(data);
+  return undefined;
+}
+
+DriveInterface.prototype.setFloatParameter = async function setFloatParameter(
+  paramId,
+  value
+) {
+  let retry = 3;
+  let v;
+  while (retry !== 0) {
+    try {
+      return await _setFloatParameter.bind(this)(paramId, value);
+    } catch (e) {
+      retry = retry - 1;
+    }
+  }
+
+  if (v) {
+    return v;
+  }
+
+  throw new SocketTimeout();
+};
+
 DriveInterface.prototype.deviceTransaction = function deviceTransaction(pkt) {
   return new Promise(async (resolve, reject) => {
     const self = this;