Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover can provide larger proof.trace_length value that is still valid #476

Open
randomsleep opened this issue Oct 15, 2024 · 1 comment

Comments

@randomsleep
Copy link
Contributor

The verifier only uses the padded_trace_length to verify the proof:

let padded_trace_length = proof.trace_length.next_power_of_two();

The prover can provide a larger proof.trace_length value (e.g. proof.trace_length + 1) that is still valid. In this way the proof.trace_length won't reflect the real trace length.

A simple proof of concept is that in the Jolt prove function we change the trace length and the test still works.

-        let trace_length = trace.len();
+        let trace_length = trace.len() + 1;

We may need to either verify the trace length in the verifier or specify proof.trace_length to be proof.padded_trace_length.

@randomsleep randomsleep changed the title Prover can provide larger proof.trace_length that is still valid Prover can provide larger proof.trace_length value that is still valid Oct 15, 2024
@moodlezoup
Copy link
Collaborator

hmm I think in theory the verifier shouldn't need the trace length at all; it's currently being passed around to generate the Spartan key but I think that's an artifact of how that code is being reused between prover and verifier... so with some refactoring we should hopefully be able to avoid sending the trace length entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants